| commit | 7088891e07d8b4f7c1977ed9c9f5d00338ade31e | [log] [tgz] |
|---|---|---|
| author | Edwin Kempin <ekempin@google.com> | Thu Aug 08 06:45:03 2024 +0000 |
| committer | Edwin Kempin <ekempin@google.com> | Mon Aug 12 09:40:26 2024 +0000 |
| tree | 127d39335ec548de64c7754c2ef0d84891896395 | |
| parent | b3d9ab2aa6ea25a74ac0529e9271713ace6dcd85 [diff] |
PathCodeOwners: Flatten the return type (step 3/3) Add a AutoValue builder for PathCodeOwnersResult. This allows us to get rid of local vars to collect the result data. Having an AutoValue builder for PathCodeOwnersResult also allows us to unify how results within PathCodeOwners are passed between methods. At the moment the resolveImports method has a return value to return resolved/unresolved imports and the messages, and in addition it gets a CodeOwnerConfig.Builder passed in to write out relevant parts of the imported CodeOwnerConfig. Using 2 different approaches to return results is confusing. If we have an AutoValue builder for PathCodeOwnersResult we can just use this builder to collect all the results. Change-Id: I69c13959dc08517d9dbc8e144d7a28b0fe388582 Signed-off-by: Edwin Kempin <ekempin@google.com>
This plugin provides support for defining code owners for files in a repository.
If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.
For a detailed description of the plugin functionality please refer to the plugin documentation.
IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide.
NOTE: The plugin documentation only renders correctly when the plugin is installed in Gerrit and the documentation is accessed via https:///plugins/code-owners/Documentation/index.html. If you want to read the documentation before installing the plugin, you can find it properly rendered here.
From the root of the gerrit repository.
bazel test //plugins/code-owners/web:karma_test
For testing the plugin with the Gerrit FE Dev Helper the command below builds
bazel build //plugins/code-owners/web:code-owners
ln -s bazel-bin/plugins/code-owners/web/code-owners.js polygerrit-ui/app/plugins/
and let the Dev Helper redirect from .+/plugins/code-owners/static/code-owners.js to http://localhost:8081/plugins/code-owners.js.