Google Git
Sign in
gerrit / plugins / code-owners / 35652d547507438dae69a54e6551e4aabf0ebf20
commit35652d547507438dae69a54e6551e4aabf0ebf20[log] [tgz]
authorEdwin Kempin <ekempin@google.com>Fri Aug 09 09:59:51 2024 +0000
committerEdwin Kempin <ekempin@google.com>Mon Aug 12 06:08:32 2024 +0000
tree6bf27c30be9433c2aac2a0f6644a07da05eae1c6
parent48e36fe7ed0693de0f5ab3a866119f86357b5fa1 [diff]
Fix wrongly returned import when per file owner is transitively imported

If an OWNERS file A has a global import of an OWNERS file B that has a
per-file import, then the per-file import was returned twice, once as
expected for OWNERS file B and once wrongly for OWNERS file A.

When resolving imports for per-file code owner sets we must only look at
the per-file code owner sets from the OWNERS file that is being
resolving and not at per-file code owner sets which have already been
imported via global imports.

Change-Id: I0ec04d121f4b1f81ca75e8f52c5e15c3a75f32b1
Signed-off-by: Edwin Kempin <ekempin@google.com>
Reviewed-on: https://gerrit-review.googlesource.com/c/plugins/code-owners/+/434757
Tested-by: Zuul <zuul-63@gerritcodereview-ci.iam.gserviceaccount.com>
Reviewed-by: Kamil Musin <kamilm@google.com>
2 files changed
tree: 6bf27c30be9433c2aac2a0f6644a07da05eae1c6
  1. java/
  2. javatests/
  3. proto/
  4. resources/
  5. web/
  6. .gitignore
  7. .gitreview
  8. BUILD
  9. LICENSE
  10. README.md
README.md

Gerrit Code Review code-owners plugin

This plugin provides support for defining code owners for files in a repository.

If the code-owners plugin is enabled, changes can only be submitted if all touched files are covered by approvals from code owners.

For a detailed description of the plugin functionality please refer to the plugin documentation.

IMPORTANT: Before installing/enabling the plugin follow the instructions from the setup guide.

NOTE: The plugin documentation only renders correctly when the plugin is installed in Gerrit and the documentation is accessed via https:///plugins/code-owners/Documentation/index.html. If you want to read the documentation before installing the plugin, you can find it properly rendered here.

JavaScript Plugin

From the root of the gerrit repository.

bazel test //plugins/code-owners/web:karma_test

For testing the plugin with the Gerrit FE Dev Helper the command below builds

    bazel build //plugins/code-owners/web:code-owners
    ln -s bazel-bin/plugins/code-owners/web/code-owners.js polygerrit-ui/app/plugins/

and let the Dev Helper redirect from .+/plugins/code-owners/static/code-owners.js to http://localhost:8081/plugins/code-owners.js.