tree 8814d979b268761a0ebc159f1b1de12141cb10e2
parent d6bdde50af78e0d45af4b891f0883ce8b9c41585
author Ewout Maertens <ewoutm@arista.com> 1757656208 +1000
committer Ewout Maertens <ewoutm@arista.com> 1757657132 +1000
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQEzBAABCAAdFiEE2KJQqSrJG9vKu3nb+QdvAqEBfXQFAmjDuC4ACgkQ+QdvAqEB
 fXQ5Hwf/WNqTmgSCll1azM/vOn7rYlq8I7WW/FRKs85pbHEZ7dPFMPUAZXgQsCRd
 cPEft3B00P7jIul1jFFq0knm5qrtg1yG0UMzOMEQChqeA8VV+WIUXGbxORRPebwx
 Fy+pL0GAsIVzg1QqVb66H/E+of/q2+Vk8e6JQwj5aqW7K7eNg9AEN/zH/5uK7GwX
 J49Tueh+5vK0shYnY3dYTnBbQogPAW7orBQCjO094RjaEEG+e+pFp2GHC2nVAun6
 xf0uRWYbtSdA7hpAOU/lovNK2d82esDG30AzePYQBxb34KIus1M+xVnT5IKyggAH
 kKP/QDRg+95OpTjYlq+zehsgWHJhDw==
 =aOgX
 -----END PGP SIGNATURE-----

chatgpt: clean up temporary files during uploadRepoFiles

We noticed our gerrit instance running out of disk space and found a
series of json files generated under `/tmp`. The structure looked like:
/tmp/<repository_name><hash>.json

We notice these temp files would get generated upon a CR change-merged
event:
"<timestamp & user> INFO  com.googlesource.gerrit.plugins.aicodereview
.listener.GerritListener : Processing event: com.google.gerrit.server
.events.ChangeMergedEvent@commit-hash"

The timestamp of this event would always match the timestamp of the
json file created under `tmp`. These files also only get created for
CRs merged in a repo where ai-code-review is created.

We pin-pointed the issue to createTempFileWithContent in this plugin.
There is a deleteOnExit() clause for this, but it does not seem to
delete the files in all situations.

Some of these files are quite large, as they contain the whole content
of a CR.

This change is a proposed fix for deleting a file in a finally clause
in case it has not been removed yet and still exists.

Change-Id: I1fb62f95c20b509cc756a0702d112e5eb44cc20a